Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace init scripts with a dependency on itself #3674

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

devoto13
Copy link
Collaborator

This has the same result (symlink to the karma in the node_modules), but has two benefits:

  • karma developers don't need to run extra command
  • no peer dependency warnings when npm install is run

This has the same result (symlink to the `karma` in the node_modules), but has two benefits:

- karma developers don't need to run extra command
- no peer dependency warnings when `npm install` is run
@karmarunnerbot
Copy link
Member

Build karma 577 completed (commit d6386a3a5c by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 578 completed (commit d6386a3a5c by @devoto13)

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@johnjbarton johnjbarton merged commit cc9420d into karma-runner:master Apr 12, 2021
@devoto13 devoto13 deleted the remove-init branch May 4, 2021 14:33
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
…er#3674)

This has the same result (symlink to the `karma` in the node_modules), but has two benefits:

- karma developers don't need to run extra command
- no peer dependency warnings when `npm install` is run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants