This repository has been archived by the owner on May 12, 2021. It is now read-only.
arm/pci: add create pci bus path support for acpi #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devimc
approved these changes
Jan 20, 2021
jongwu
added a commit
to jongwu/tests
that referenced
this pull request
Jan 21, 2021
As acpi has been supported, it should be reasonable to offer uefi rom before using it. Here is a script to give a easy way to install uefi rom. Also we should test kata with acpi enabled. Depends-on: github.com/kata-containers/runtime#3121 Depends-on: github.com/kata-containers/packaging#1169 Depends-on: github.com/kata-containers/agent#882 Fixes: kata-containers#3149 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
jongwu
added a commit
to jongwu/tests
that referenced
this pull request
Jan 22, 2021
As acpi has been supported, it should be reasonable to offer uefi rom before using it. Here is a script to give a easy way to install uefi rom. Also we should test kata with acpi enabled. Depends-on: github.com/kata-containers/runtime#3121 Depends-on: github.com/kata-containers/packaging#1169 Depends-on: github.com/kata-containers/agent#882 Fixes: kata-containers#3149 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
|
/test |
PCI bus path in qemu/arm64 is different between acpi enabled and disabled. It's better to check if there is a pci bus path for acpi which is a static value before try to offer a varying pci bus path for no acpi. Fixes: kata-containers#881 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
=======================================
Coverage 57.75% 57.75%
=======================================
Files 18 18
Lines 2275 2275
=======================================
Hits 1314 1314
Misses 804 804
Partials 157 157 |
|
hello @lifupan @jodh-intel , any comments? |
|
hello @jodh-intel @devimc , any comments? |
|
@jongwu lgtm - thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCI bus path in qemu/arm64 is different between acpi enabled and
disabled. It's better to check if there is a pci bus path for acpi which
is a static value before try to offer a varying pci bus path for no acpi.
Fixes: #881
Signed-off-by: Jianyong Wu jianyong.wu@arm.com
@jodh-intel @devimc