-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel config for NVIDIA DPU/ConnectX adapter #9620
base: main
Are you sure you want to change the base?
Conversation
FYI: in the guest VM:
|
@zvonkok PR updated, PTAL, thanks |
@l8huang You need to bump |
95edfb3
to
71c5f45
Compare
Thanks for the heads up, version updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l8huang I see that this PR is for adding kernel configs for NVIDIA Mellanox ConnectX network adaptor. While the PR looks good overall, the usage of NVIDIA here and in tools/packaging/kernel/configs/fragments/dpu/nvidia.conf file name you added is slightly confusing, also due to the fact we have fragments present for NVIDIA gpu as well.
Since the configs added in the fragment here have Mellonox/MLX in the name, can we rename this to Mellanox instead to reduce confusion.
I am suggesting to replace
-D : DPU/SmartNIC vendor, only NVIDIA. => -D : DPU/SmartNIC vendor, only Mellanox.
@amshinde Mellanox was acquired by NVIDIA, the products are named under NVIDIA now. |
@l8huang I understand that, I suggested the rename to Mellanox to avoid confusion with Nvidia GPU, and since the kernel configs refer to Mellanox rather than Nvidia. |
According to https://en.wikipedia.org/wiki/Mellanox_Technologies:
If one googles Mellanox Technologies, the top results point to NVIDIA. TBH: I don't see too much confusion, the option says the @zvonkok what do you think? |
@amshinde Would you mind merging this PR as it is? If any confusion arises later, I will address and amend it accordingly. |
@l8huang There is a merge conflict now, can you rebase this PR? |
With Nvidia DPU or ConnectX network adapter, VF can do VFIO passthrough to guest VM in `guest-kernel` mode. In the guest kernel, the adapter's driver is required to claim the VFIO device and create network interface. Signed-off-by: Lei Huang <leih@nvidia.com>
@amshinde thanks for heads up, just rebased. |
With Nvidia DPU or ConnectX network adapter, VF can do VFIO passthrough to guest VM in
guest-kernel
mode. In the guest kernel, the adapter's driver is required to claim the VFIO device and create network interface.