Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-rs: bugfix for root bus slot allocation #9814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Apokleos
Copy link
Contributor

There's no point that allocating root bus slot
starting from zero. This is used to correct the
starting index with 1 replacing original 0.

Fixes #9813

There's no point that allocating root bus slot
starting from zero. This is used to correct the
starting index with 1 replacing original 0.

Fixes kata-containers#9813

Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
@Apokleos
Copy link
Contributor Author

CC @zvonkok @lifupan

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Jun 11, 2024
@zvonkok
Copy link
Contributor

zvonkok commented Jun 11, 2024

I am confused why we cannot start at zero.

@amshinde
Copy link
Member

Same question as @zvonkok, why cant the index start from 0?

@Apokleos Apokleos added the wip Work in Progress (PR incomplete - needs more work or rework) label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task wip Work in Progress (PR incomplete - needs more work or rework)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: runtime-rs's PCI root bus slot should start from 1 in vmm dragonball case
4 participants