Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image rs bump bad84c7 #9828

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Image rs bump bad84c7 #9828

wants to merge 2 commits into from
+312 −244

Conversation

stevenhorsman
Copy link
Member

@stevenhorsman stevenhorsman commented Jun 12, 2024 •
edited

  • Try bumping image-rs to latest version to pull in the latest security fixes
  • Bump the patch version of rust we are using to build the agent to see if that is enough to build the new create version

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Jun 12, 2024
@katacontainersbot katacontainersbot added size/huge Largest and most complex task (probably needs breaking into small pieces) and removed size/tiny Smallest and simplest task labels Jun 12, 2024
@stevenhorsman
Copy link
Member Author

FYI I think there is possibly a bug in image-rs, maybe about layer ordering? We are seeing some failures like:

failed to create containerd task: failed to create shim task: failed to handle layer: hasher sha256: Operation not supported (os error 95): unknown

e.g. https://github.com/kata-containers/kata-containers/actions/runs/9486782210/job/26146223525?pr=9828 .

It doesn't happen every time, but pulling registry.k8s.io/e2e-test-images/agnhost:2.21 seems to be the most consistent trigger of it

cc @arronwy @Xynnn007 @fidencio

@stevenhorsman
Copy link
Member Author

FYI - I've tried using registry.k8s.io/e2e-test-images/agnhost:2.21 in the image-rs pull tests and can't reproduce the error, so there might be something specific to the confidential image?

@stevenhorsman stevenhorsman force-pushed the image-rs-bump-bad84c7 branch 3 times, most recently from 4fe9cc3 to 3f7fb5c Compare June 19, 2024 09:02
@stevenhorsman
agent: Bump image-rs
50d7b9e 
- Bump the commit of image-rs we are pulling in to get the latest updates
including security fixes

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman
versions: Bump agnhost version
03762a8 
Try bumping agnhost version from 2.21 to 2.41

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test size/huge Largest and most complex task (probably needs breaking into small pieces)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevenhorsman @katacontainersbot