tests/k8s: run for qemu-runtime-rs on AKS #9833
Conversation
| @@ -100,6 +101,7 @@ teardown() { | |||
| [ "${KATA_HYPERVISOR}" == "firecracker" ] && skip "test not working see: ${fc_limitations}" | |||
| [ "${KATA_HYPERVISOR}" == "fc" ] && skip "test not working see: ${fc_limitations}" | |||
| [ "${KATA_HYPERVISOR}" == "dragonball" ] && skip "test not working see: ${dragonball_limitations}" | |||
| [ "${KATA_HYPERVISOR}" == "qemu-runtime-rs" ] && skip "test not working see: ${dragonball_limitations}" | |||
There was a problem hiding this comment.
Why here has ${dragonball_limitations} ? I am curious about it. Can this be changed as [ "${KATA_HYPERVISOR}" == "dragonball" ] || [ "${KATA_HYPERVISOR}" == "qemu-runtime-rs" ] && skip "test not working see: ${dragonball_limitations}" if both of them use the "test not working see: ${dragonball_limitations}" ?
There was a problem hiding this comment.
Good point @Apokleos
dragonball_limitations is #6621 that points to kata-containers/tests#5391 then kata-containers/tests#5392. IIUC this is an old limitation of runtime-rs (lack of vCPU resize) that was implemented for dragonball in #6289 . So maybe one can try to enable it on the dragonball job to see if it really works now?
vCPU resize should still not work with qemu-runtime-rs because CPU hot-plugging isn't implemented yet. Did I get it correctly @pmores ?
Anyway, I will write an accurate skip message to qemu-runtime-rs
| @@ -9,7 +9,7 @@ load "${BATS_TEST_DIRNAME}/../../common.bash" | |||
| load "${BATS_TEST_DIRNAME}/tests_common.sh" | |||
|
|
|||
| setup() { | |||
| [[ "${KATA_HYPERVISOR}" = "cloud-hypervisor" ]]&& skip "test not working https://github.com/kata-containers/kata-containers/issues/9039" | |||
| [[ "${KATA_HYPERVISOR}" = "cloud-hypervisor" || "${KATA_HYPERVISOR}" = "qemu-runtime-rs" ]] && skip "test not working https://github.com/kata-containers/kata-containers/issues/9039" | |||
There was a problem hiding this comment.
The k8s-number-cpus.bats creates a pod with two containers, limiting each CPU to "500m". It should not work on qemu-runtime-rs due (again) lack of hot-plugging support. So I will re-write the skip message.
@jodh-intel @amshinde is it the case for cloud-hypervisor too?
| @@ -9,7 +9,7 @@ load "${BATS_TEST_DIRNAME}/../../common.bash" | |||
| load "${BATS_TEST_DIRNAME}/tests_common.sh" | |||
|
|
|||
| setup() { | |||
| [ "${KATA_HYPERVISOR}" == "dragonball" ] || [ "${KATA_HYPERVISOR}" == "cloud-hypervisor" ]&& \ | |||
| [ "${KATA_HYPERVISOR}" == "dragonball" ] || [ "${KATA_HYPERVISOR}" == "cloud-hypervisor" ] || [ "${KATA_HYPERVISOR}" == "qemu-runtime-rs" ] && \ | |||
The following tests are disabled because they fail (alike with dragonball): - k8s-cpu-ns.bats - k8s-number-cpus.bats - k8s-sandbox-vcpus-allocation.bats Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
The following tests are disabled because they fail (alike with dragonball):
Fixes #9804