gha: Do not fail when collecting artifacts #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wainersm
reviewed
Jun 13, 2024
| @@ -86,7 +86,7 @@ jobs: | |||
| run: bash tests/integration/kubernetes/gha-run.sh run-tests | |||
|
|
|||
| - name: Collect artifacts ${{ matrix.vmm }} | |||
| run: bash tests/integration/kubernetes/gha-run.sh collect-artifacts | |||
| run: bash tests/integration/kubernetes/gha-run.sh collect-artifacts || true | |||
There was a problem hiding this comment.
Hi @GabyCT ! Thanks for promptly working on this one!
One question that I have and I forgot to mention on the issue is whether the next step Archive artifacts ${{ matrix.vmm }} is going to fail in case /tmp/artifacts doesn't exist.
ah, also, while here, I think we want to have this step if: always() so it runs in case the test fails.
There was a problem hiding this comment.
@wainersm so I added the if always step
GabyCT
force-pushed
the
topic/fixartifacts
branch
from
eee113f
to
3dfb2d3
Compare
wainersm
approved these changes
Jun 13, 2024
beraldoleal
reviewed
Jun 13, 2024
GabyCT
force-pushed
the
topic/fixartifacts
branch
2 times, most recently
from
d42de85
to
eeb467b
Compare
This PR will avoid the failures when collecting artifacts for the gha. This will ensure that we collect and archive system's data for the purpose of debugging. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will avoid the failures when collecting artifacts for the gha.
This will ensure that we collect and archive system's data for the
purpose of debugging.