runtime: fix missing of VhostUserDeviceReconnect parameter assignment #9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
/test |
Apokleos
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Thx @markyangcc for your contribution.
Could you please add this message to git's commit ？You can follow the example
IMO, this maybe only involve small changes but as a result of go format causing the whole HypervisorConfig change(L909 ->L979)
Commit 'ca02c9f5124e' implements the vhost-user-blk reconnection functionality,
However, it has missed assigning VhostUserDeviceReconnect when new the QEMU
HypervisorConfig, resulting in VhostUserDeviceReconnect always set to default value 0.
Real change is this line, most of changes caused by go format,
return vc.HypervisorConfig{
// ...
VhostUserDeviceReconnect: h.VhostUserDeviceReconnect,
}, nil
Fixes: kata-containers#9848
Signed-off-by: markyangcc <mmdou3@163.com>
Yes, real change is add below line, most of changes caused by go format, Also, commit message updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below commit implements the vhost-user-blk reconnection functionality,
runtime: add reconnect timeout for vhost user block
However, this commit has missed assigning
VhostUserDeviceReconnectwhen new the QEMU HypervisorConfig, resulting inVhostUserDeviceReconnectalways set to default value 0.Fixes: #9848