Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test suite #427

Closed
thijstriemstra opened this issue Apr 6, 2015 · 4 comments
Closed

add test suite #427

thijstriemstra opened this issue Apr 6, 2015 · 4 comments
Assignees
@thijstriemstra

Comments

@thijstriemstra
Copy link
Contributor

Running grunt from root of repository should execute test suite.

Also see http://blog.chrislowis.co.uk/2014/04/30/testing-web-audio.html
@thijstriemstra thijstriemstra self-assigned this Apr 11, 2015
@thijstriemstra
Copy link
Contributor Author

Created a jasmine setup with grunt tasks for tests and coverage. PR follows.

@katspaugh
Copy link
Owner

Cool, looking forward!

@thijstriemstra
Copy link
Contributor Author

Also found https://github.com/HumbleSoftware/js-imagediff which might be useful. For now I'm adding tests for util.js only so we can expand on that.

thijstriemstra added a commit to thijstriemstra/wavesurfer.js that referenced this issue Apr 11, 2015
@thijstriemstra
add test suite (katspaugh#427)
b9020c5
@thijstriemstra
Copy link
Contributor Author

Well, the travis build for my wavesurfer fork is green: https://travis-ci.org/thijstriemstra/wavesurfer.js/builds/58101652

So I think we're good to go. I also added extra checkers (https://github.com/JamieMason/Jasmine-Matchers) because some basic things like startsWith are not included in jasmine.

@thijstriemstra thijstriemstra mentioned this issue Apr 11, 2015
Merged
thijstriemstra added a commit to thijstriemstra/wavesurfer.js that referenced this issue Apr 11, 2015
@thijstriemstra
add coveralls (katspaugh#427)
d163a21
thijstriemstra added a commit to thijstriemstra/wavesurfer.js that referenced this issue Apr 11, 2015
@thijstriemstra
add coveralls (katspaugh#427)
528e5f9
thijstriemstra added a commit to thijstriemstra/wavesurfer.js that referenced this issue Apr 11, 2015
@thijstriemstra
also jshint tests (katspaugh#427)
2e7af0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thijstriemstra thijstriemstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thijstriemstra @katspaugh