Switch to bsd license #1060
Switch to bsd license #1060
Conversation
Adding the BSD license.
LICENSE
Outdated
| @@ -0,0 +1,29 @@ | |||
| BSD 3-Clause License | |||
|
|
|||
| Copyright (c) 2017, katspaugh | |||
There was a problem hiding this comment.
I'd say katspaugh and contributors. And look up when first commit of project was done and use that in copyright date, e.g. 2014-2017
package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| "url": "git://github.com/katspaugh/wavesurfer.js.git" | |||
| }, | |||
| "author": "", | |||
| "license": "CC-BY-3.0", | |||
| "license": "BSD 3-Clause License", | |||
There was a problem hiding this comment.
incorrect identifier, it should be BSD-3-Clause.
|
@thijstriemstra I am seeing the miss on the bower.json. Where else is needed for the README? I changed the license mentions there. |
|
https://github.com/katspaugh/wavesurfer.js#license (ah yes, missed that, you fixed that already) I suggest you do a grep for 'Creative commons' through all files, probably are more. |
|
That's the original README from the katspaugh repo. The change is in my fork: I'll run the grep while fixing the other changes to fully verify I haven't missed anything else. |
example/audio-element/index.html
Outdated
| @@ -99,11 +99,11 @@ <h1 itemprop="name">Media Element Fallback Example</h1> | |||
|
|
|||
| <div class="footer row"> | |||
| <div class="col-sm-12"> | |||
| <a rel="license" href="https://creativecommons.org/licenses/by/3.0/deed.en_US"><img alt="Creative Commons License" style="border-width:0" src="https://i.creativecommons.org/l/by/3.0/80x15.png" /></a> | |||
| <a rel="license" href="https://opensource.org/licenses/BSD-3-Clause"><img alt="BSD--Clause License" style="border-width:0" src="https://img.shields.io/badge/License-BSD%203--Clause-blue.svg" /></a> | |||
There was a problem hiding this comment.
the 3 is missing in the img alt for all examples.
|
Thanks much, @blakemurdock and @thijstriemstra! |
|
@katspaugh lets release it as 1.4.0? |
|
Released 👍 |
* Create LICENSE Adding the BSD license. * Change all references to CC license to point to the new BSD license * Extend the license through the examples directory
* Create LICENSE Adding the BSD license. * Change all references to CC license to point to the new BSD license * Extend the license through the examples directory
Please make sure you provide the information below:
Converting to the BSD License from the CC license
Short description of changes:
This PR added the license and updated all dist/ level minified files to reference the new license.
Breaking in the external API:
N/A
Breaking changes in the internal API:
N/A
Todos/Notes:
Need to update wavesurfer-js.org to reflect these changes
Related Issues and other PRs:
#1050