Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the current region (#1148) #1180

Merged
merged 2 commits into from
Sep 2, 2017
Merged

Get the current region (#1148) #1180

merged 2 commits into from
Sep 2, 2017

Conversation

dimidd
Copy link
Contributor

@dimidd dimidd commented Jul 31, 2017

Get the current region, i.e. the smallest region that contains the current time.
If several such regions exist, we take the first.
Return null if none exist.

Implements #1148

Signed-off-by: Dimid Duchovny dimidd@gmail.com

Signed-off-by: Dimid Duchovny <dimidd@gmail.com>
@mspae
Copy link
Contributor

mspae commented Aug 18, 2017

Can you add a unit test for the function?

@dimidd
Copy link
Contributor Author

dimidd commented Aug 21, 2017 via email

@mspae
Copy link
Contributor

mspae commented Aug 21, 2017

I just saw we don't have any tests yet. Either you create a regions.spec.js in /spec and add your tests there. Or leave it out and the person that adds all the other tests for the regions plugin (at some point) also adds it.

@mspae mspae merged commit e50c1ed into katspaugh:master Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants