Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1226 #967: Refactoring of timeline plugin #1238

Merged
merged 8 commits into from
Oct 31, 2017

Conversation

mspae
Copy link
Contributor

@mspae mspae commented Oct 29, 2017

Short description of changes:

  • Clean timeline container so consecutive file loads don't produce empty canvases
  • Refactor timeline plugin to be more like the multi canvas renderer
  • Performance optimisations (as described here) for rerenders (when zooming)
  • Added labelPadding parameter to configure the space between notches and labels
  • Added zoomDebounce parameter to (optionally) specify a debounce timeout when zooming. (Useful for very large files
  • Added jsdoc comments

Breaking in the external API:

/

Breaking changes in the internal API:

/

Todos/Notes:

Related Issues and other PRs:

@mspae mspae changed the title Fix #1226: Refactoring of timeline plugin Fix #1226 #967: Refactoring of timeline plugin Oct 29, 2017
@thijstriemstra thijstriemstra merged commit a34a90a into katspaugh:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad zooming performance when using timeline plugin
2 participants