Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1265: Minimap - Attach click event to the wrapper #1315

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Fix #1265: Minimap - Attach click event to the wrapper #1315

merged 1 commit into from
Jan 26, 2018

Conversation

roboswank
Copy link
Contributor

@roboswank roboswank commented Jan 26, 2018 •
edited by thijstriemstra
Loading

Short description of changes:

Finished click event navigation logic in the minimap plugin

Related Issues and other PRs:

fixes #1265

@roboswank
Fix katspaugh#1265: Minimap - Attach click event to the wrapper
6386a17 
Attach click event to drawer wrapper and fire event with the position
@thijstriemstra
Copy link
Contributor

thanks!

@thijstriemstra thijstriemstra merged commit fbb6d59 into katspaugh:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.0 Minimap: canvas click does nothing; Initial load does not display waveform
2 participants
@roboswank @thijstriemstra