Regions plugin - Scroll when near edges of container #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mouse or region edge is near the container's edges, scroll in that direction.
roboswank
commented
Feb 5, 2018
| @@ -639,12 +780,25 @@ export default class RegionsPlugin { | |||
| region = this.add(params || {}); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Not sure if duration needs to be called on each interaction - but moved it to eventDown so it is not being called on every mouse move.
|
@roboswank can you add a changelog item for this? |
thijstriemstra
changed the title
thijstriemstra
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dragging, if mouse or region edge is near the container's edges, scroll in that direction.
Short description of changes:
Added checks, within region mouse move events, to scroll the container when within a certain threshold of the container's edges.
New region plugin options available:
scroll- defaults to truescrollSpeed- defaults to 1scrollThreshold- defaults to 10Related Issues and other PRs:
fixes #430