Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build library using webpack 4 #1376

Merged
merged 13 commits into from
May 21, 2018
Merged

build library using webpack 4 #1376

merged 13 commits into from
May 21, 2018

Conversation

thijstriemstra
Copy link
Contributor

No description provided.

@katspaugh
Copy link
Owner

The CI build seems to fail.

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented May 21, 2018 •
edited
Loading

@katspaugh should be fixed now. Can you enable this repository on coveralls.io? Oh nevermind it's already enabled for years:

Repo Added 11 Apr 2015 09:36PM UTC

katspaugh
katspaugh approved these changes May 21, 2018
View reviewed changes
Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@thijstriemstra thijstriemstra merged commit 5452cc3 into master May 21, 2018
@thijstriemstra thijstriemstra deleted the webpack4 branch May 21, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katspaugh katspaugh katspaugh approved these changes

@mspae mspae Awaiting requested review from mspae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thijstriemstra @katspaugh