Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use custom script processor node #1389

Merged
merged 4 commits into from
Jun 12, 2018

Conversation

thijstriemstra
Copy link
Contributor

New audioScriptProcessor option that allows you to specify a custom script processor node (required for safari 11 so you can pass in one after a user gesture).

also fixes #1384

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.437% when pulling 3e153c3 on script-processor-safari into dcdf3aa on master.

@coveralls
Copy link

coveralls commented Jun 10, 2018

Coverage Status

Coverage decreased (-0.04%) to 68.4% when pulling b2761c0 on script-processor-safari into dcdf3aa on master.

Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@thijstriemstra thijstriemstra merged commit 9c1588d into master Jun 12, 2018
@thijstriemstra thijstriemstra deleted the script-processor-safari branch June 12, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run build error
3 participants