Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo proposal #1420

Merged
merged 10 commits into from
Aug 19, 2018
Merged

logo proposal #1420

merged 10 commits into from
Aug 19, 2018

Conversation

entonbiba
Copy link
Contributor

@entonbiba entonbiba commented Aug 6, 2018

Svg and png versions if required will upload jpg version as well.

Wavesurfer.js Logo

  • full logo png/svg version
  • text only logo png/svg version
  • symbol only logo png/svg version
  • black and white versions
  • move files to folder specific (/assets/) folder

logo

svg and png versions if required will upload jpg version as well
@entonbiba entonbiba self-assigned this Aug 6, 2018
@entonbiba
Copy link
Contributor Author

@katspaugh not sure if it should be included in the master branch or just the gh-pages branch only?

@entonbiba entonbiba mentioned this pull request Aug 6, 2018
@coveralls
Copy link

coveralls commented Aug 6, 2018

Coverage Status

Coverage remained the same at 68.462% when pulling d49b2dd on entonbiba-logo into 00b1e81 on master.

@katspaugh
Copy link
Owner

katspaugh commented Aug 7, 2018

@entonbiba thank you! Could you also commit the non-textual part of the logo as a separate file?

As for the textual part, I think it should be all lower-case and .js should probably be the same size as the rest (to differentiate better from the well-known Wavesurfer project).

As for the branch, I think master is OK. Maybe in a folder assets? I'll update the HTML in gh-pages to include the logo, too.

@entonbiba
Copy link
Contributor Author

@katspaugh I created white/black text versions and also symbol only versions all in png and svg formats.

@katspaugh
Copy link
Owner

Awesome, thank you very much @entonbiba!

Do you want to update the website as well, or should I do it?

@entonbiba entonbiba mentioned this pull request Aug 15, 2018
3 tasks
@entonbiba
Copy link
Contributor Author

@katspaugh I updated the docs, #1426

@thijstriemstra thijstriemstra merged commit dc759de into master Aug 19, 2018
@thijstriemstra
Copy link
Contributor

thanks @entonbiba

@thijstriemstra thijstriemstra deleted the entonbiba-logo branch August 19, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants