Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spectrogram plugin: properly remove event listeners #1581

Merged
merged 6 commits into from
Mar 6, 2019
Merged

spectrogram plugin: properly remove event listeners #1581

merged 6 commits into from
Mar 6, 2019

Conversation

thijstriemstra
Copy link
Contributor

fixes #1571

@coveralls
Copy link

coveralls commented Mar 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 69.447% when pulling b5ecc31 on spectrogram-listeners-1571 into 2cf0fb3 on master.

@thijstriemstra thijstriemstra mentioned this pull request Mar 5, 2019
Closed
@thijstriemstra thijstriemstra merged commit 888cc5e into master Mar 6, 2019
@thijstriemstra thijstriemstra deleted the spectrogram-listeners-1571 branch March 6, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katspaugh katspaugh Awaiting requested review from katspaugh

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spectrogram cannot be destroyed
2 participants
@thijstriemstra @coveralls