Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regions plugin: don't assign to module object #1823

Merged
merged 1 commit into from
Dec 7, 2019
Merged

regions plugin: don't assign to module object #1823

merged 1 commit into from
Dec 7, 2019

Conversation

mustafa0x
Copy link
Contributor

@mustafa0x mustafa0x commented Dec 7, 2019 •
edited
Loading

As it's invalid (I noticed when bundling with rollup).

Reproduce in a browser with something like the following:

<script type=module>
import * as util from './util.js';
util.a = 1;
</script>

@mustafa0x
regions.js: don't assign to module object
8064c9f 
As it's invalid (I noticed when bundling with rollup).

Reproduce in a browser with something like the following:
```js
<script type=module>
import * as util from './util.js';
util.a = 1;
</script>
```
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.622% when pulling 8064c9f on mustafa0x:patch-2 into 1822277 on katspaugh:master.

@thijstriemstra thijstriemstra changed the title regions.js: don't assign to module object regions plugin: don't assign to module object Dec 7, 2019
@thijstriemstra
Copy link
Contributor

thanks!

@thijstriemstra thijstriemstra merged commit 0914f29 into katspaugh:master Dec 7, 2019
@mustafa0x mustafa0x deleted the patch-2 branch December 9, 2019 11:10
sandiz pushed a commit to sandiz/wavesurfer.js that referenced this pull request May 30, 2020
@mustafa0x @sandiz
regions plugin: don't assign to module object (katspaugh#1823)
686db73 
As it's invalid (I noticed when bundling with rollup).

Reproduce in a browser with something like the following:
```js
<script type=module>
import * as util from './util.js';
util.a = 1;
</script>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mustafa0x @coveralls @thijstriemstra