Double click on marker handler to delete it #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Delete Mark on handler dble click | ||
| this.drawer.on('mark-dblclick', function(e) { | ||
| var mark = my.markers[e.target.parentNode.id]; |
There was a problem hiding this comment.
My comment is the same as before: the wavesurfer object shouldn't know anything about marks implementation. We should pass the mark id as the event argument instead.
katspaugh
added a commit
that referenced
this pull request
Jun 4, 2014
Double click on marker handler to delete it
|
Merged, thank you! Sorry I've been missing your last commit for so long. |
|
You're welcome ! |
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.