When splitting channels, allow coloring and filtering of channels #1947
Conversation
|
Yea it's similar. The differences are: #1889 creates two canvases and waveforms in order to color the different waves. This pr adds changes into existing methods to apply colors. The shape of the parameters are different. That one adds a waveColor2 and progressColor2 so it allows coloring two channels. This one sets colors using a map from channel index to a { waveColor, progressColor } object so it should work with audio that has more channels than stereo. This one includes hiding different channels and stacking the wave forms on top of each other which are not part of #1889. |
|
I've been trying to figure out why the appveyor build is failing but I can't seem to replicate the bug on local builds. Do you have any advice on how to debug this? |
Appveyor has a mind of it's own, don't worry about it. |
Do you want to drop the news in that pull request @katspaugh (and close it..)? Very unfortunate that contribution could not be used. |
Our project would like to allow the user to filter out channels from the audio for playing/viewing. The filtering for playing will be done via setFilters. This pr is to add the rest via a new parameter splitChannelsOptions and a new method setFilteredChannels.
Short description of changes:
Add splitChannelsOptions parameter that applies if splitChannels is true.
Contains the following options:
overlay - draws channels on over each other when splitting
channelColors - defines colors for channels individually
filteredChannels - channel indices to filter (do not draw on the waveform)
Add setFilteredChannels method to update the filteredChannels param.
Update split channels example to include info on the above.
Breaking in the external API:
none
Breaking changes in the internal API:
none
Todos/Notes:
The splitChannelsOptions currently only works with drawWave.
Related Issues and other PRs:
coloring:
#1889