Drawer: removed private methods #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If can be a useful thing :) |
thijstriemstra
suggested changes
Jun 9, 2020
There was a problem hiding this comment.
thanks @marizuccara! can you also add a short, single sentence to the changelog?
|
@marizuccara there are only changelog updates in this pull request, something must've gone wrong. |
Yes sorry, I made a mess |
thijstriemstra
approved these changes
Jun 13, 2020
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
* changelog * drawer: removed private methods and vars * fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
Removed private methods from wavesurfer drawer, so a new one can be created, inheriting the existing ones, and overriding only the necessary features.
Breaking changes in the internal API:
Removed all private clauses from
drawer.js,drawer.canvasentry.jsanddrawer.multicanvas.js.