performance: use clip-path css instead of width #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents browsers from continuously making layout engine passes.
katspaugh
requested changes
Jun 25, 2020
marizuccara
approved these changes
Jun 25, 2020
|
Tried in Chrome/Windows and it works correctly. I have not Safari, so I cannot see the performance there. But this improvement seems to have sense, so I approve |
thijstriemstra
approved these changes
Jun 25, 2020
|
ok, all fixed. @katspaugh is this part of the officially required style for the project (template strings over concatenation, single quotes")? could this be in es-lint rather than a round-trip on every PR? |
|
Thanks, @osheroff! |
katspaugh
approved these changes
Jun 25, 2020
thijstriemstra
changed the title
osheroff
added a commit
that referenced
this pull request
Jul 5, 2020
this killed off the cursor functionality. we're using the right-hand-border of the progressWave to show a "audio cursor" element.
osheroff
added a commit
that referenced
this pull request
Jul 6, 2020
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
* use a clip-path css mask instead of changing width this prevents browsers from continuously making layout engine passes. * code review fixes; code style, comments * add changelog entry * add PR number to changelog Co-authored-by: Thijs Triemstra <info@collab.nl>
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
…)" (katspaugh#1994) this killed off the cursor functionality. we're using the right-hand-border of the progressWave to show a "audio cursor" element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constantly changing the width of the multi-canvas
progressWaveelement triggers a layout pass in the browser. This doesn't seem to be a huge problem for Chrome, but in Safari on mac it's worth quite a hunk of performance.This is Safari pre-patch (I played the whole file on /example/html-init/ for these tests):
Safari post-patch:
Chrome seems to jitter more and benefit less, but note the ~10% of rendering that we seem to save:
pre-patch:
post-patch:
would love to know if I'm missing anything with the logic here or if other people can run benchmarks and see if this feels like a win.