Regions: remove cursor col-resize when disable region resizing #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osheroff
suggested changes
Jun 25, 2020
thijstriemstra
suggested changes
Jun 26, 2020
There was a problem hiding this comment.
see inline comments by @osheroff. Also needs a changelog entry.
- fixed regions handles style assignment - changelog
|
sorry I din't get a notification that you had pushed new code. LGTM. |
osheroff
approved these changes
Jun 30, 2020
thijstriemstra
approved these changes
Jul 3, 2020
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
- fixed regions handles style assignment - changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
Added
updateHandlesResizemethod to remove cursorcol-resizestyle when updating region with resize setted to false, and to restorecol-resizewhen is setted to trueBreaking changes in the internal API:
updateHandlesResizemethodRelated Issues and other PRs:
fixes #1963