Code cleanup for Observer class #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marizuccara
approved these changes
Aug 14, 2020
thijstriemstra
approved these changes
Aug 14, 2020
thijstriemstra
changed the title
thijstriemstra
pushed a commit
that referenced
this pull request
Sep 24, 2020
marizuccara
pushed a commit
to marizuccara/wavesurfer.js
that referenced
this pull request
Nov 28, 2020
* Initialize handlers dictionary in constructor and remove conditional assignment * reset handlers to empty object in unAll * strict equality check, add type hint comments and cleanup some code
marizuccara
pushed a commit
to marizuccara/wavesurfer.js
that referenced
this pull request
Nov 28, 2020
…2069) * Revert "Code cleanup for Observer class (katspaugh#2041)" This reverts commit 590d9cc. * Update CHANGES.md
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
* Initialize handlers dictionary in constructor and remove conditional assignment * reset handlers to empty object in unAll * strict equality check, add type hint comments and cleanup some code
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
…2069) * Revert "Code cleanup for Observer class (katspaugh#2041)" This reverts commit 590d9cc. * Update CHANGES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete a todo note: initialize Observer handlers in constructor and remove checks in
unandonmethods, this.handlers can never be null anymore.Also clean up a little bit (=== instead of ==, jsdoc and shorter arrow functions)