Fix for unhandled AbortError thrown during cancelAjax #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please add a changelog entry and go ahead and squash merge it. |
thijstriemstra
approved these changes
Sep 13, 2020
|
no more abort errors in travis/appveyor either so I guess it worked. |
Yep. And a local |
marizuccara
pushed a commit
to marizuccara/wavesurfer.js
that referenced
this pull request
Nov 28, 2020
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
Cancel the current ajax request's ReadableStream during wavesurfer destroy to prevent unhandled AbortError (which was breaking tests).
Firefox only bug?
Related Issues and other PRs:
Closes #2042