WaveSurfer load() should accept HTMLMediaElement when using WebAudio #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing WebAudio backend
thijstriemstra
suggested changes
Dec 30, 2020
|
I had to make a new file for WebAudio tests, let me know if it looks OK, I don't know how you'd like to structure the tests |
thijstriemstra
approved these changes
Jan 18, 2021
into fix-webaudio-load
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
…atspaugh#2148) * Allow users to pass in HTMLMediaElement to the load() function when using WebAudio backend * add webaudio tests * add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WaveSurfer.load function's documentation says that the url parameter can be a string or a HTMLMediaElement, but when using the
WebAudiobackend, the loadBuffer function will assume the URL is always a string, and send incorrect HTTP requests like this:Breaking in the external API:
Technically this affects the external API, but instead of breaking existing code, it will fix currently broken code.