Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seeking issue for WebAudio backends #2151

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix seeking issue for WebAudio backends #2151

merged 3 commits into from
Jan 8, 2021

Conversation

todoroff
Copy link
Contributor

@todoroff todoroff commented Jan 5, 2021

Revert the changes from #2045 but only for WebAudio backends.

Fixes #2149

@coveralls
Copy link

coveralls commented Jan 5, 2021

Coverage Status

Coverage increased (+0.08%) to 82.546% when pulling b7eb371 on todoroff:master into 374e1b0 on katspaugh:master.

@todoroff todoroff marked this pull request as ready for review January 5, 2021 22:54
@thijstriemstra thijstriemstra merged commit d2c419a into katspaugh:master Jan 8, 2021
@Hideman85
Copy link

Hi, I'm wondering if you can make a patch release 4.3.1 on npm repo to have this fix available?

@thijstriemstra
Copy link
Contributor

see #2153

@Hideman85
Copy link

Hideman85 commented Jan 13, 2021

Super and when is it planed to be on npm? Oh I just note that it has been opened 3hours ago so I suppose it will be released soon ;)

sandiz pushed a commit to sandiz/wavesurfer.js that referenced this pull request Sep 1, 2021
* fix seeking issue for WebAudio backends

* update changelog: fix webaudio seeking

* use ticket nr in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seek Behavior Changed in 4.2.0
4 participants