markers plugin: markers at the begin/end of file were screwing up seeking #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markers placed at the beginning or the end of a region weren't properly overflowing, instead they pushed the wavesurfer container to be wider and that messed up calculations when seeking around a waveform.
Always. And yea, it's included in 4.6.0. |
thijstriemstra
changed the title
|
ok, changelog entry added. |
thijstriemstra
approved these changes
Mar 8, 2021
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
…king (katspaugh#2208) * markers at the beginning/end of the file were screwing up seeking markers placed at the beginning or the end of a region weren't properly overflowing, instead they pushed the wavesurfer container to be wider and that messed up calculations when seeking around a waveform. * add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markers placed at the beginning or the end of a region weren't properly overflowing, instead they pushed the wavesurfer container to be wider and that messed up calculations when seeking around a waveform.
Does this need a CHANGELOG? not sure if you've released the marker stuff into the wild yet.