Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v5.2.0 #2332

Merged
merged 10 commits into from
Aug 16, 2021
Merged

release: v5.2.0 #2332

merged 10 commits into from
Aug 16, 2021

Conversation

thijstriemstra
Copy link
Contributor

No description provided.

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Aug 2, 2021 •
edited
Loading

I had to revert the change made for Gatsby by @NSpehler: f1a9429#diff-3bf4b033d26e8f94bc1f9d63819e5fd4f9f2875f469cf6a5f1cc70eea6b1f859

Because it was breaking the build with this error: https://github.com/katspaugh/wavesurfer.js/runs/3221915834

Uncaught TypeError: Cannot read property 'webpackChunkWaveSurfer' of undefined
TypeError: Cannot read property 'webpackChunkWaveSurfer' of undefined
    at http://localhost:9876/absoluteplugin-api.spec.1864405643.js?94a9c48aa6956fb06894bcddd9d24498e81dddc1:17:46
    at webpackUniversalModuleDefinition (http://localhost:9876/absoluteplugin-api.spec.1864405643.js?94a9c48aa6956fb06894bcddd9d24498e81dddc1:15:24)
    at http://localhost:9876/absoluteplugin-api.spec.1864405643.js?94a9c48aa6956fb06894bcddd9d24498e81dddc1:16:3

Related ticket seems to be:

If anyone knows a fix, please let me know or I'll release 5.2.0 like this and we'll have to add Gatsby compatibility again later.

@thijstriemstra
Copy link
Contributor Author

Because it was breaking the build

Looks like globalOject: typeof window !== 'undefined' ? window : this might be a workaround..

@thijstriemstra thijstriemstra mentioned this pull request Aug 10, 2021
Merged
@thijstriemstra thijstriemstra merged commit d27b75e into master Aug 16, 2021
@thijstriemstra thijstriemstra deleted the release-520 branch August 16, 2021 13:52
sandiz pushed a commit to sandiz/wavesurfer.js that referenced this pull request Sep 1, 2021
@thijstriemstra @sandiz
release: v5.2.0 (katspaugh#2332)
495b6fd 
* update changelog

* bump version: 5.2.0

* disable globalObject due to build issue

* update dev dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marizuccara marizuccara Awaiting requested review from marizuccara

@osheroff osheroff Awaiting requested review from osheroff

@sundayz sundayz Awaiting requested review from sundayz

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thijstriemstra