Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minimap plugin: changed regions function name to resolve ambiguities #2483

Merged
merged 3 commits into from
Mar 25, 2022
Merged

minimap plugin: changed regions function name to resolve ambiguities #2483

merged 3 commits into from
Mar 25, 2022

Conversation

palufra90
Copy link
Contributor

@palufra90 palufra90 commented Mar 17, 2022 •
edited by thijstriemstra
Loading

Short description of changes:

In the minimap plugin the function regions() and an object regions had the same name. This was causing an issue when the minimap was trying to display initialized regions.

Related Issues and other PRs:

fixes #2482
Other issue talking about this problem: #2128

@thijstriemstra thijstriemstra changed the title changed regions function name to resolve ambiguities regions plugin: changed regions function name to resolve ambiguities Mar 17, 2022
@thijstriemstra thijstriemstra changed the title regions plugin: changed regions function name to resolve ambiguities minimap plugin: changed regions function name to resolve ambiguities Mar 17, 2022
thijstriemstra
thijstriemstra suggested changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @palufra90, can you also add a changelog entry?

thijstriemstra
thijstriemstra approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a changelog entry. thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.308% when pulling c04d663 on palufra90:master into f76adfe on katspaugh:master.

@thijstriemstra thijstriemstra merged commit 55bba32 into katspaugh:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The minimap plug-in does not display initialized regions.
3 participants
@palufra90 @coveralls @thijstriemstra