Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: export types for CJS modules #2910

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Fix: export types for CJS modules #2910

merged 2 commits into from
Jun 18, 2023

Conversation

katspaugh
Copy link
Owner

Resolves #2877.

When module resolution in tsconfig is set to Node, it needs types explicitly exported by the package.

See https://www.typescriptlang.org/docs/handbook/esm-node.html

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d2eea6
Status:⚡️  Build in progress...

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 88f9168 into beta Jun 18, 2023
2 of 3 checks passed
@katspaugh katspaugh deleted the cjstypes branch June 18, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta: Typescript types aren't being resolved properly for imports
1 participant