Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: replace webpack with rollup #2992

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Chore: replace webpack with rollup #2992

merged 3 commits into from
Jul 9, 2023

Conversation

katspaugh
Copy link
Owner

The Rollup config now exports 3 different types of modules:

  • .esm.js for browsers and Deno
  • .cjs for Node.js
  • .min.js for browsers via a global script tag

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

🤖 OpenAI

High-level Summary

The codebase is undergoing a significant refactoring to replace webpack with Rollup. This involves modifying the build configuration, changing file extensions, and updating the export behavior of several classes. These changes can potentially impact the behavior, compatibility, and visibility of the code. Therefore, a thorough review is necessary to ensure correctness, maintainability, and compatibility.

File Summaries

File(s) Summary
rollup.config.js, webpack.config.js, webpack.config.plugins.js The build configuration is being refactored to replace webpack with Rollup. The changes include modifications to the entry point, module rules, output settings, and addition of extension aliases. These changes should be reviewed together as they can impact the behavior and compatibility of the code.
cypress/e2e/umd.html The HTML file is updated to reference the new Rollup output files with different extensions. Although it seems like a minor change, it can impact the code's behavior and compatibility if not correctly updated or if there are any issues with the new file formats.
src/plugins/envelope.ts The EnvelopePlugin class has been changed from being exported to being a private class within the file. This change can potentially impact the behavior of the code and should be reviewed thoroughly.
src/plugins/hover.ts The HoverPlugin class is no longer exported as part of the module. This change can potentially impact the behavior of the code and should be reviewed thoroughly.
src/plugins/minimap.ts The MinimapPlugin class is no longer exported as part of the module. It has been changed to a non-exported class. This change may impact the usage and behavior of the code and should be reviewed thoroughly.
src/plugins/record.ts The RecordPlugin class has been modified by removing the export keyword from the class declaration. This change can potentially impact the behavior of the code and should be reviewed thoroughly.
src/plugins/regions.ts The Region and RegionsPlugin classes no longer have the export keyword, making them non-exported from the module. This change may impact the behavior of the code if other modules or components rely on importing and using these classes. A thorough review is necessary to ensure compatibility and functionality.
src/plugins/spectrogram.ts The SpectrogramPlugin class is no longer exported as part of the module. This change can potentially impact the behavior of the code and should be reviewed thoroughly.
src/plugins/timeline.ts The TimelinePlugin class has been modified by adding and removing CSS properties related to positioning and styling. These changes may impact the visual appearance and behavior of the timeline component, requiring a thorough review to avoid unintended side effects or regressions.
src/wavesurfer.ts The WaveSurfer class is no longer exported as part of the module. This change may impact the behavior of the code and should be reviewed thoroughly.

Please review the individual files for detailed analysis and potential improvements.


Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.

Files ignored due to filter (2)

Ignored files

  • package.json
  • yarn.lock

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc866f4
Status: ✅  Deploy successful!
Preview URL: https://c2bf1e04.wavesurfer-js.pages.dev
Branch Preview URL: https://rollup.wavesurfer-js.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 0467efe into main Jul 9, 2023
5 checks passed
@katspaugh katspaugh deleted the rollup branch July 9, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant