Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add stopAT in WebAudioPlayer #3325

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

xinyuaixiaoyu
Copy link
Contributor

Add function for precise playback

Short description

Resolves #

Implementation details

How to test it

Screenshots

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes

Add function for precise playback
@katspaugh katspaugh changed the title Update webaudio.ts stopAT Feat: add stopAT in WebAudioPlayer Nov 8, 2023
@katspaugh
Copy link
Owner

Thanks for the PR! There's a build issue:

src/webaudio.ts(103,9): error TS7006: Parameter 'timeSeconds' implicitly has an 'any' type.

add timeSeconds type
@katspaugh katspaugh merged commit 09f774e into katspaugh:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants