Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Record] restore interact and cursor width on destoy #3375

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3304

Implementation details

Wavesurfer options are now restored when the Record plugin is destroyed.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 378899e
Status: ✅  Deploy successful!
Preview URL: https://5ca626cf.wavesurfer-js.pages.dev
Branch Preview URL: https://fix-record.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit 2a333b9 into main Dec 3, 2023
4 checks passed
@katspaugh katspaugh deleted the fix-record branch December 3, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordPlugin not resetting interact and cursorWidth options to their original values
1 participant