Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaElement#getDuration throwing TypeError fixed #720

Merged
merged 1 commit into from
May 12, 2016
Merged

MediaElement#getDuration throwing TypeError fixed #720

merged 1 commit into from
May 12, 2016

Conversation

f4z4on
Copy link

@f4z4on f4z4on commented May 11, 2016 •
edited
Loading

WaveSurfer.MediaElement#getDuration throwed TypeError: Not enough arguments in Safari 9.1. It also violated contract specified in HTML Time ranges.

This should fix #719.

MediaElement#getDuration throwing TypeError fixed
aaf818b 
WaveSurfer.MediaElement#getDuration throwed `TypeError: Not enough
arguments` in Safari 9.1. It also violated contract specified in [HTML
Time
ranges](https://developers.whatwg.org/the-video-element.html#dom-timeranges-end).

This should fix #719.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 4.745% when pulling aaf818b on frzng:seekable-end-fix into 622322d on katspaugh:master.

@katspaugh katspaugh merged commit c5adffe into katspaugh:master May 12, 2016
@katspaugh
Copy link
Owner

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safari 9.1 throws TypeError: Not enough arguments in #getDuration
3 participants
@f4z4on @coveralls @katspaugh