MediaElement Preload #854
MediaElement Preload #854
Conversation
| var my = this; | ||
|
|
||
| var media = document.createElement(this.mediaType); | ||
| media.controls = this.params.mediaControls; | ||
| media.autoplay = this.params.autoplay || false; | ||
| media.preload = 'auto'; | ||
| media.preload = preload == null ? 'auto' : preload; |
| @@ -49,14 +49,15 @@ WaveSurfer.util.extend(WaveSurfer.MediaElement, { | |||
| * @param {String} url path to media file | |||
| * @param {HTMLElement} container HTML element | |||
| * @param {Array} peaks array of peak data | |||
| * @param {String} preload HTML 5 preload attribute value | |||
|
Looks good to me! |
|
@katspaugh should be corrected now :P |
| var my = this; | ||
|
|
||
| var media = document.createElement(this.mediaType); | ||
| media.controls = this.params.mediaControls; | ||
| media.autoplay = this.params.autoplay || false; | ||
| media.preload = 'auto'; | ||
| media.preload = preload == null ? 'auto' : preload; |
There was a problem hiding this comment.
@katspaugh Arf, github webditor shows this as perfectly aligned. I created the indentation by copy pasting from the above line.
Well, should be corrected now.
| @@ -412,6 +412,7 @@ var WaveSurfer = { | |||
| this.decodeArrayBuffer(arraybuffer, (function (buffer) { | |||
| this.backend.buffer = buffer; | |||
| this.drawBuffer(); | |||
| this.fireEvent('waveform_ME_noPeaks'); | |||
There was a problem hiding this comment.
This is something extra, let's remove.
There was a problem hiding this comment.
@katspaugh Yep, it will be my next proposition, we'll talk about that later 😄
|
@katspaugh I hope indentations are solved now. GitHub webditor doesn't display invisible characters --' |
|
Merged, thanks! |
|
@katspaugh Thanks for having accepted this request. Cheers ! |
| @@ -1192,14 +1192,15 @@ WaveSurfer.util.extend(WaveSurfer.MediaElement, { | |||
| * @param {String} url path to media file | |||
| * @param {HTMLElement} container HTML element | |||
| * @param {Array} peaks array of peak data | |||
| * @param {String} preload HTML 5 preload attribute value | |||
There was a problem hiding this comment.
Damn, the indentation is still wrong here.
There was a problem hiding this comment.
@katspaugh Arf, GitHub web editor is really not friendly with indentation display... :/
Do you want me to fix this ou can you do it ?
There was a problem hiding this comment.
I'll do it when doing a release, no worries.
There was a problem hiding this comment.
@katspaugh Sorry for the inconvenience. Indentations are not displayed and created equally between editors. --'
|
@X-Raym can you also update the changelog? |
|
@thijstriemstra ok, what version number should I put ? |
|
1.2.3, @X-Raym |
|
@thijstriemstra @katspaugh #857 Done ! |
Add a ‘preload’ parameter to load function to choose the preload HTML5 audio attribute value if MediaElement.