Only call media.load() if it exists #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running code that uses Wavesurfer under PhantomJS (even if not explicitly testing the Wavesurfer code), the JS interpreter crashes because PhantomJS DOM `<audio>` elements don't have a `load()` method. This change skips that one line if the method doesn't exist.
katspaugh
approved these changes
Dec 5, 2016
|
Cool, thanks! |
|
Released in v 1.2.8. |
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Feb 5, 2017
When running code that uses Wavesurfer under PhantomJS (even if not explicitly testing the Wavesurfer code), the JS interpreter crashes because PhantomJS DOM `<audio>` elements don't have a `load()` method. This change skips that one line if the method doesn't exist.
thijstriemstra
pushed a commit
that referenced
this pull request
Feb 6, 2017
* fixed wrong var reference causing the bottom half of the waves to not draw * replaced loops of this.canvases with correct for loop or forEach where possible * turned unnecessary let into const in multicanvas * Only call media.load() if it exists (#875) * When running code that uses Wavesurfer under PhantomJS (even if not explicitly testing the Wavesurfer code), the JS interpreter crashes because PhantomJS DOM `<audio>` elements don't have a `load()` method. This change skips that one line if the method doesn't exist. * Apply correct normalize absmax calculation to drawBars() (#916) * fix draw wrong position while playing backward seeking (#918) * fix draw wrong position while playing backward seeking * fix spelling mistake * add getPlaybackRate (#936) * added es6 method short notation for #f185d97c825a92bfb69be80091587a9a19f66594 * Updated render function for drawPeaks/getPeaks (#959) * Updated the render function to call the new version of the getPeaks and drawPeaks calls which now require start and end parameters. Fixes flat waveform drawing in minimap plugin. * changed vars to const where possible in ported bugfix commits from master branch * fixed split channel call to drawWave and drawPeaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running code that uses Wavesurfer under PhantomJS (even if not explicitly testing the Wavesurfer code), the JS interpreter crashes because PhantomJS DOM
<audio>elements don't have aload()method. This change skips that one line if the method doesn't exist.