check if browser supports AudioContext.close in webaudio.js #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add check for browser support of AudioContext.close(). This is only supported by Chrome 43+ and FireFox 40+ for now. Edge and other non supported browsers will give an undefined error. https://developer.mozilla.org/en-US/docs/Web/API/AudioContext/close // check if browser supports AudioContext.close() if(typeof this.ac.close() !== 'undefined'){ this.ac.close(); }
src/webaudio.js
Outdated
| @@ -286,7 +286,10 @@ WaveSurfer.WebAudio = { | |||
| // close the audioContext if it was created by wavesurfer | |||
| // not passed in as a parameter | |||
| if (!this.params.audioContext) { | |||
| this.ac.close(); | |||
| // check if browser supports AudioContext.close() | |||
| if(typeof this.ac.close() !== 'undefined'){ | |||
There was a problem hiding this comment.
can you add spaces around the parentheses like line 288? Weird our style checker didn't notice it, I thought it did before.
There was a problem hiding this comment.
@thijstriemstra done
thijstriemstra
suggested changes
Feb 4, 2017
src/webaudio.js
Outdated
| @@ -286,7 +286,10 @@ WaveSurfer.WebAudio = { | |||
| // close the audioContext if it was created by wavesurfer | |||
| // not passed in as a parameter | |||
| if (!this.params.audioContext) { | |||
| this.ac.close(); | |||
| // check if browser supports AudioContext.close() | |||
| if (typeof this.ac.close() !== 'undefined'){ | |||
|
Also can you not use 'Update filename.js' as title for your PRs but give it a few word title that describes the change better. |
entonbiba
changed the title
thijstriemstra
approved these changes
Feb 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add check for browser support of AudioContext.close(). This is only supported by Chrome 43+ and FireFox 40+ for now. Edge and other non supported browsers will give an undefined error. #949
https://developer.mozilla.org/en-US/docs/Web/API/AudioContext/close
// check if browser supports AudioContext.close()
if(typeof this.ac.close() !== 'undefined'){
this.ac.close();
}