Don't leak exceptions from managed threads #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
commented
Sep 28, 2023
edsko
force-pushed
the
edsko/dont-leak-exceptions
branch
from
6654f95
to
f093214
Compare
|
Fixed. |
kazu-yamamoto
approved these changes
Sep 28, 2023
|
Merged. |
edsko
added a commit
to edsko/http2
that referenced
this pull request
Jul 19, 2024
In kazu-yamamoto#92 we added an exception handler that was meant to catch _all_ exceptions (sync and async). This got changed in kazu-yamamoto#114 (specifically, kazu-yamamoto@52a9619): when we moved from `Control.Exception` to `UnliftIO.Exception`, we got a different behaviour for `catch` and friends (see well-typed/grapesy#193 (comment)) for a full list. This commit fixes some unintended consequences of this change.
edsko
added a commit
to edsko/http2
that referenced
this pull request
Jul 23, 2024
In kazu-yamamoto#92 we added an exception handler that was meant to catch _all_ exceptions (sync and async). This got changed in kazu-yamamoto#114 (specifically, kazu-yamamoto@52a9619): when we moved from `Control.Exception` to `UnliftIO.Exception`, we got a different behaviour for `catch` and friends (see well-typed/grapesy#193 (comment)) for a full list. This commit fixes some unintended consequences of this change.
edsko
added a commit
to edsko/http2
that referenced
this pull request
Jul 24, 2024
In kazu-yamamoto#92 we added an exception handler that was meant to catch _all_ exceptions (sync and async). This got changed in kazu-yamamoto#114 (specifically, kazu-yamamoto@52a9619): when we moved from `Control.Exception` to `UnliftIO.Exception`, we got a different behaviour for `catch` and friends (see well-typed/grapesy#193 (comment)) for a full list. This commit fixes some unintended consequences of this change.
edsko
added a commit
to edsko/http2
that referenced
this pull request
Jul 24, 2024
In kazu-yamamoto#92 we added an exception handler that was meant to catch _all_ exceptions (sync and async). This got changed in kazu-yamamoto#114 (specifically, kazu-yamamoto@52a9619): when we moved from `Control.Exception` to `UnliftIO.Exception`, we got a different behaviour for `catch` and friends (see well-typed/grapesy#193 (comment)) for a full list. This commit fixes some unintended consequences of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a subtle but useful change to
forkManaged[Unmask]: instead of usingonException(which is whatbracketdoes), we usecatch:onExceptionwill rethrow the exception, but this is not very useful: the only exception handler that sits above the thread is the one installed by default byforkIOWithUnmask, which just prints the exception to the terminal. As a result, when the thread manager shuts down managed threads, sometimes thoseKilledByHttp2ThreadManagerexceptions were printed to the terminal, interfering with the regular output of the program. (Specifically, I was observing this with the thread spawned byforkAndEnqueueWhenReadyinArch/Sender.hs.)