Fixed bug when using jquery.metadata #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the jquery.metadata plugin is in use then the original metadata object would be passed in as the timeEntry settings object. This meant that the element's metadata object would be extended with the timeEntry settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object returned from the
$(this).metadata()call is passed into_connectTimeEntry()as theinitialSettingsobject. The object is extended with timeEntry options which then become visible to other callers ofmetadata(), e.g. the jquery.validate plug-in.My fix is to extend a new object so that the original metadata object is not modified. I've included a test that demonstrates the problem.