Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.9.0-alpha.1] feat: top level variable back reference #1104

Merged
merged 3 commits into from
May 8, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #247
Closes kcl-lang/kpm#241
Closes #1176
Closes #1253

feat: top level variable back reference

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/context.rs
  • kclvm/compiler/src/codegen/llvm/emit.rs
  • kclvm/compiler/src/codegen/llvm/module.rs
  • kclvm/runtime/src/_kcl_run.rs
  • kclvm/runtime/src/eval/**

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/irrelevant_order/simple_6/main.k
  • test/grammar/schema/irrelevant_order/simple_7/main.k
  • test/grammar/schema/irrelevant_order/simple_8/main.k

@Peefy Peefy added runtime Issues or PRs related to kcl runtime including value and value opertions codegen labels Mar 4, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 4, 2024
@Peefy Peefy requested a review from zong-zhe March 4, 2024 12:08
@Peefy Peefy force-pushed the top-level-var-back-reference branch 5 times, most recently from f2c8efd to c67699d Compare March 6, 2024 09:48
@Peefy Peefy changed the title [WIP] feat: top level variable back reference [WIP v0.9-alpha.1] feat: top level variable back reference Mar 7, 2024
@Peefy Peefy force-pushed the top-level-var-back-reference branch from c67699d to 598ebd6 Compare March 7, 2024 08:15
@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 9000600409

Details

  • 62 of 88 (70.45%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 71.406%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/_kclvm_addr.rs 0 1 0.0%
kclvm/runtime/src/context/api.rs 0 1 0.0%
kclvm/compiler/src/codegen/llvm/node.rs 7 11 63.64%
kclvm/compiler/src/codegen/llvm/context.rs 49 59 83.05%
kclvm/runtime/src/_kcl_run.rs 0 10 0.0%
Totals Coverage Status
Change from base Build 9000204859: 0.3%
Covered Lines: 53271
Relevant Lines: 74603

💛 - Coveralls

@Peefy Peefy requested a review from He1pa March 7, 2024 08:49
@Peefy Peefy mentioned this pull request Mar 7, 2024
16 tasks
@Peefy Peefy force-pushed the top-level-var-back-reference branch from 598ebd6 to 29f4b43 Compare March 8, 2024 06:01
@Peefy Peefy force-pushed the top-level-var-back-reference branch 3 times, most recently from 5f0bb85 to fe7d248 Compare March 22, 2024 13:44
@Peefy Peefy force-pushed the top-level-var-back-reference branch 3 times, most recently from 5a3cbe8 to 325d4d8 Compare May 6, 2024 08:39
@Peefy Peefy changed the title [WIP v0.9-alpha.1] feat: top level variable back reference [v0.9.0-alpha.1] feat: top level variable back reference May 6, 2024
@Peefy Peefy removed request for He1pa and zong-zhe May 6, 2024 09:10
@Peefy Peefy force-pushed the top-level-var-back-reference branch 3 times, most recently from 4aa4b17 to 656b120 Compare May 6, 2024 10:17
@Peefy Peefy force-pushed the top-level-var-back-reference branch 9 times, most recently from ac45220 to 5069c1e Compare May 7, 2024 08:55
@Peefy Peefy self-assigned this May 7, 2024
Peefy added 3 commits May 8, 2024 18:53
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the top-level-var-back-reference branch from d4910de to 6132e8d Compare May 8, 2024 10:53
@Peefy Peefy merged commit 57852c3 into kcl-lang:main May 8, 2024
10 checks passed
@Peefy Peefy deleted the top-level-var-back-reference branch July 30, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
2 participants