Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed a formatting error when inserting import stmt into a KCL f… #1307

Merged
merged 1 commit into from
May 13, 2024

Conversation

zong-zhe
Copy link
Contributor

…ile with comments by OverrideFile api

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…ile with comments by OverrideFile api

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the fix label May 13, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone May 13, 2024
@zong-zhe zong-zhe requested a review from Peefy May 13, 2024 10:51
@zong-zhe zong-zhe self-assigned this May 13, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9061620410

Details

  • 200 of 715 (27.97%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 71.016%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/node.rs 174 689 25.25%
Totals Coverage Status
Change from base Build 9058787793: -0.4%
Covered Lines: 53482
Relevant Lines: 75310

💛 - Coveralls

@Peefy Peefy merged commit e2c778f into kcl-lang:main May 13, 2024
10 checks passed
@zong-zhe zong-zhe deleted the fix-override-import branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants