Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl toolchain trait for the native toolchain #1363

Merged
merged 5 commits into from
May 28, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: impl toolchain trait for the native toolchain

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/config/src/modfile.rs
  • kclvm/driver/Cargo.toml
  • kclvm/driver/src/client/fs.rs
  • kclvm/driver/src/client/git.rs
  • kclvm/driver/src/client/mod.rs
  • kclvm/driver/src/client/oci.rs
  • kclvm/driver/src/lib.rs
  • kclvm/driver/src/test_data/kpm_update/kcl.mod

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/driver/src/tests.rs

@Peefy Peefy added this to the v0.9.0 Release milestone May 27, 2024
@Peefy Peefy requested review from He1pa and zong-zhe May 27, 2024 10:17
@Peefy Peefy force-pushed the feat-native-toolchain branch 8 times, most recently from 357434b to c4543e1 Compare May 27, 2024 15:10
Signed-off-by: peefy <xpf6677@163.com>
Peefy added 2 commits May 28, 2024 10:01
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9263030436

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 296 of 506 (58.5%) changed or added relevant lines in 13 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 71.003%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/driver/src/toolchain.rs 14 15 93.33%
kclvm/driver/src/tests.rs 72 74 97.3%
kclvm/api/src/service/jsonrpc.rs 0 7 0.0%
kclvm/api/src/service/capi.rs 0 14 0.0%
kclvm/api/src/service/service_impl.rs 0 21 0.0%
kclvm/driver/src/client/oci.rs 19 58 32.76%
kclvm/driver/src/client/git.rs 28 80 35.0%
kclvm/driver/src/client/mod.rs 141 215 65.58%
Files with Coverage Reduction New Missed Lines %
kclvm/api/src/service/jsonrpc.rs 1 0.0%
kclvm/api/src/service/capi.rs 1 76.54%
kclvm/sema/src/core/symbol.rs 6 46.8%
kclvm/ast/src/config.rs 7 0.0%
Totals Coverage Status
Change from base Build 9261110061: -0.09%
Covered Lines: 54340
Relevant Lines: 76532

💛 - Coveralls

Peefy added 2 commits May 28, 2024 11:04
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy merged commit 1f262c7 into kcl-lang:main May 28, 2024
8 of 10 checks passed
@Peefy Peefy deleted the feat-native-toolchain branch May 28, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants