Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema resolve insert attr op #1402

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 6, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #1400

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/src/ty.rs
  • kclvm/evaluator/src/union.rs
  • kclvm/runtime/src/value/val_dict.rs
  • kclvm/runtime/src/value/val_type.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/config_op/insert/insert_5/main.k
  • test/grammar/schema/config_op/insert/insert_6/main.k

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the fix-schema-resolve-append-attr-op branch from 580ecdb to d0adf9e Compare June 6, 2024 03:02
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9394442264

Details

  • 0 of 38 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 71.075%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_type.rs 0 1 0.0%
kclvm/evaluator/src/ty.rs 0 2 0.0%
kclvm/runtime/src/value/val_dict.rs 0 35 0.0%
Totals Coverage Status
Change from base Build 9370250877: -0.03%
Covered Lines: 55027
Relevant Lines: 77421

💛 - Coveralls

@Peefy Peefy merged commit 0b210eb into kcl-lang:main Jun 6, 2024
10 of 11 checks passed
@Peefy Peefy deleted the fix-schema-resolve-append-attr-op branch June 6, 2024 03:37
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9394442264

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 38 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 71.075%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_type.rs 0 1 0.0%
kclvm/evaluator/src/ty.rs 0 2 0.0%
kclvm/runtime/src/value/val_dict.rs 0 35 0.0%
Totals Coverage Status
Change from base Build 9370250877: -0.03%
Covered Lines: 55027
Relevant Lines: 77421

💛 - Coveralls

@Peefy Peefy mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in adding to list
3 participants