-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource rules to krm-kcl spec #54
Conversation
Please take a look, @Peefy |
I think we should first implement this feature in the corresponding code before modifying the test cases. |
I have added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! LGTM
Could you please fix the CI? |
I have modified the test cases in
|
I think we should use the
Is this the correct approach @Peefy. |
I suggest keeping this field as it is consistent with Kubernetes CEL, please refer to https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/#creating -A-validatingadmissionpolicy |
Any ideas on what might be causing this error @Peefy, since I have tried out correcting any possible syntax or test case error. |
Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add resource matching rules to config.go Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix build and test errors Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add test case for missing resource rules Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated yaml test files Signed-off-by: shruti2522 <shruti.apc01@gmail.com> test case set to optional Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected syntax error in yaml Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fixed yaml formatting in config_test.go Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fixed yaml formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated logic handling for MatchResourceRules Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: add resource rules to krm-kcl spec Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Done with the changes @Peefy |
Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #13
2. What is the scope of this PR (e.g. component or file name):
kcl-lang/krm-kcl/pkg/options/testdata/resource_list
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Added resource matching rules to the krm-kcl spec
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: