refactor(scaler): compare error with errors.Is
#4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e gcp* |
|
Nice improvement! Could you also update the other occurrences https://github.com/search?q=repo%3Akedacore%2Fkeda%20strings.Contains(err.Error()&type=code? |
@JorTurFer Sure! I'll push new commits soon |
Juneezee
changed the title
errors.Iserrors.Is
|
@JorTurFer Please take a look again 😃 |
|
Please @zroubalik , take a look too |
Starting from Go 1.13, errors.Is is the preferable way to compare error equality [1]. [1]: https://go.dev/blog/go1.13-errors Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
|
/run-e2e |
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Go 1.13, errors.Is is the preferable way to compare error equality.
Reference: https://go.dev/blog/go1.13-errors
Checklist
When introducing a new scaler, I agree with the scaling governance policyTests have been addedA PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)A PR is opened to update the documentation on (repo) (if applicable)