feat: Introduce "Welcome" message for new PRs #4644
Conversation
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
The goal is to add more links that give pointers to dev guide, how to fix DCO, etc but I didn't want to do it all in one PR but happy to do so if you prefer |
|
That kind of information would be beneficial indeed. I would prefer if you can include more information into the initial PR. The current state is just a noise in my opinion 😄 |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
Updated PR with some basic info: |
There was a problem hiding this comment.
I think that it would be better to put more specific stuff, that we usually check. Instead of generic contribution guidelines (which are good in general).
- Short sentence notifying users to don't forget to add Changelog entry - in alphabetical order
- Make sure the PR has attached issue & linked in the Changelog
- Reminding users to check the status of GH Actions/workflows and fix if there's a problem.
- How to fix the DCO check
I would skip the create new scaler item, we got much more PRs fixing/adding random stuff, new scalers are really a minority of PRs.
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Introduce "Welcome" message for new PRs for which we will provide guidance going forward. (more content in follow-up PR.
Checklist
Relates to #4640