remove podIdentityAzure references (but keep AzureWorkload ones)

Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com>

pkg/scalers/postgresql_scaler.go

@@ -138,7 +138,7 @@ func parsePostgreSQLMetadata(logger logr.Logger, config *scalersconfig.ScalerCon
 			params = append(params, "password="+escapePostgreConnectionParameter(password))
 			meta.connection = strings.Join(params, " ")
 		}
-	case kedav1alpha1.PodIdentityProviderAzure, kedav1alpha1.PodIdentityProviderAzureWorkload:
+	case kedav1alpha1.PodIdentityProviderAzureWorkload:
 		params, err := buildConnArray(config)
 		if err != nil {
 			return nil, authPodIdentity, fmt.Errorf("failed to parse fields related to the connection")
@@ -199,7 +199,7 @@ func getConnection(ctx context.Context, meta *postgreSQLMetadata, podIdentity ke
 	connectionString := meta.connection
 
 	switch podIdentity.Provider {
-	case kedav1alpha1.PodIdentityProviderAzure, kedav1alpha1.PodIdentityProviderAzureWorkload:
+	case kedav1alpha1.PodIdentityProviderAzureWorkload:
 		accessToken, err := getAzureAccessToken(ctx, meta, azureDatabasePostgresResource)
 		if err != nil {
 			return nil, err
@@ -236,7 +236,7 @@ func (s *postgreSQLScaler) getActiveNumber(ctx context.Context) (float64, error)
 
 	// Only one Azure case now but maybe more in the future.
 	switch s.podIdentity.Provider {
-	case kedav1alpha1.PodIdentityProviderAzure, kedav1alpha1.PodIdentityProviderAzureWorkload:
+	case kedav1alpha1.PodIdentityProviderAzureWorkload:
 		if s.metadata.azureAuthContext.token.ExpiresOn.After(time.Now().Add(time.Second * 60)) {
 			newConnection, err := getConnection(ctx, s.metadata, s.podIdentity, s.logger)
 			if err != nil {

pkg/scalers/postgresql_scaler_test.go

@@ -110,25 +110,6 @@ func TestPodIdentityAzureWorkloadPosgresSQLConnectionStringGeneration(t *testing
 	}
 }
 
-var testPodIdentityAzurePostgreSQLConnectionstring = []postgreSQLConnectionStringTestData{
-	// from meta
-	{metadata: map[string]string{"query": "test_query", "targetQueryValue": "5", "host": "localhost", "port": "1234", "dbName": "testDb", "userName": "user", "sslmode": "required"}, connectionString: "host=localhost port=1234 user=user dbname=testDb sslmode=required %PASSWORD%"},
-}
-
-func TestPodIdentityAzurePosgresSQLConnectionStringGeneration(t *testing.T) {
-	identityID := "IDENTITY_ID_CORRESPONDING_TO_USERNAME_FIELD"
-	for _, testData := range testPodIdentityAzurePostgreSQLConnectionstring {
-		meta, _, err := parsePostgreSQLMetadata(logr.Discard(), &scalersconfig.ScalerConfig{ResolvedEnv: testData.resolvedEnv, TriggerMetadata: testData.metadata, PodIdentity: kedav1alpha1.AuthPodIdentity{Provider: kedav1alpha1.PodIdentityProviderAzure, IdentityID: &identityID}, AuthParams: testData.authParam, TriggerIndex: 0})
-		if err != nil {
-			t.Fatal("Could not parse metadata:", err)
-		}
-
-		if meta.connection != testData.connectionString {
-			t.Errorf("Error generating connectionString, expected '%s' and get '%s'", testData.connectionString, meta.connection)
-		}
-	}
-}
-
 type parsePostgresMetadataTestData struct {
 	metadata    map[string]string
 	authParams  map[string]string