Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RabbitMQ Scaler to support TLS Configuration for HTTP Connections #5672

Conversation

nicholass-alcidion
Copy link
Contributor

@nicholass-alcidion nicholass-alcidion commented Apr 9, 2024

Update RabbitMQ Scaler to support TLS Configuration for HTTP Connections

Checklist

  • N/A When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • N/A A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • N/A A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5668

@nicholass-alcidion nicholass-alcidion requested a review from a team as a code owner April 9, 2024 23:54
@nicholass-alcidion
Copy link
Contributor Author

I looked for examples of how to extend the unit tests to cover setting up the HTTP Connection with TLS Config but was unable to find any example.

I am more than happy to add tests, I would just need a pointer in the right direction.

Signed-off-by: Nicholas Steicke <nicholas.steicke@alcidion.com>
@nicholass-alcidion nicholass-alcidion force-pushed the scalers/rabbitmq/http-support-tls-settings branch from 08dfc55 to f225934 Compare April 10, 2024 00:18
@JorTurFer
Copy link
Member

I am more than happy to add tests, I would just need a pointer in the right direction.

The only way to cover it is using e2e tests because unit tests doesn't tests http configurations yet, so no worries

@JorTurFer
Copy link
Member

JorTurFer commented Apr 10, 2024

/run-e2e rabbit
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) April 10, 2024 06:34
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@JorTurFer JorTurFer merged commit cfc1bfc into kedacore:main Apr 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ HTTP Triggers ignore provided TLS Configuration
2 participants